fix(server): cross-platform direct-execution guard in seed script (P3.10) - #46
Merged
Conversation
Co-Authored-By: Claude Code (Haiku) <noreply@anthropic.com>
Co-Authored-By: Claude Code (Haiku) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
What
seed.jsguarded direct execution with a naivefile://${process.argv[1]}string compare that never matches on Windows —node prisma/seed.jsexited 0 silently without seeding. Found live during the P3.8 cutover (migrations applied; demo-user login then 401'd). Now uses thepathToFileURLpattern already in src/index.js.Red-first
Functional red test: spawn
node prisma/seed.jswith a bogus DATABASE_URL → broken code exits 0 silently (red); fixed code exits non-zero with a Prisma connection error (green — proves the guard fires and the seed actually runs).Verification
Server suite 20 files / 220 tests. Gates: simplify ✓ / security ✓ (no behavior beyond guard) / deep-review ✓ (both the source-pattern and functional checks).
🤖 Generated with Claude Code
https://claude.ai/code/session_01VVPszGbfxNrVLm5diaCsFr