Implementing video geotagging - #6
Open
francescocaponio wants to merge 1 commit into
Open
Conversation
|
Thank you. I will do some tests in the coming days and report back! |
|
Hello. This looks like it works to me! Here's a set of files containing
Two things I noticed
|
Owner
Author
|
@thisisbommy you're right:
It would be nice to add some functional tests with small files with and without gps metadata to avoid those problems, but i don't have short videos, I need to generate them |
|
Thanks. Do you want me to generate some more files for you? Just let me know specifics and will sort. |
|
Hello. Just checking back in to see if you needed any more files? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #5.