Skip to content

Implementing video geotagging - #6

Open
francescocaponio wants to merge 1 commit into
mainfrom
add-location-metadata
Open

Implementing video geotagging#6
francescocaponio wants to merge 1 commit into
mainfrom
add-location-metadata

Conversation

@francescocaponio

Copy link
Copy Markdown
Owner

Solves #5.

@thisisbommy

Copy link
Copy Markdown

Thank you. I will do some tests in the coming days and report back!

@thisisbommy

thisisbommy commented Feb 15, 2026

Copy link
Copy Markdown

Hello. This looks like it works to me! Here's a set of files containing

  • An original mp4 with GPS data "actionmanual.mp4"
  • An original mp4 with no GPS data "actionnogps.mp4"
  • The output of both having been processed by the tool
  • The terminal log

Two things I noticed

  • I seemed to have to give an output file name in the command to make the tool write, but the name I specified was ignored
  • When no GPS data is in the file, it's still processed with blank co-ordinates added (ideal would be skipped)

@francescocaponio

Copy link
Copy Markdown
Owner Author

@thisisbommy you're right:

  • I was adding the output file name parameter, but then I noticed that you can pass an array of input files, so it was easier to generate the output name starting from the input filename, but I forgot to remove the parameter.
  • forgot to manage the empty case.

It would be nice to add some functional tests with small files with and without gps metadata to avoid those problems, but i don't have short videos, I need to generate them

@thisisbommy

Copy link
Copy Markdown

Thanks. Do you want me to generate some more files for you? Just let me know specifics and will sort.

@thisisbommy

Copy link
Copy Markdown

Hello. Just checking back in to see if you needed any more files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants