Fix the build: /_bridge/statuses reads its body through the shared readPost - #1708
Merged
Conversation
…adPost #1703 added the statuses route on top of the file-local readJsonBody, and #1704 moved that reader to http.ts in the same hour; the two merged without a textual conflict, so main's pnpm build fails with "Cannot find name 'readJsonBody'". The route now runs the same POST preamble as the bridge's other routes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1703 added the statuses route on top of the file-local
readJsonBody, and #1704 moved that reader tohttp.tsin the same hour; the two merged without a textual conflict, sopnpm buildon main fails withCannot find name 'readJsonBody'(CI run 32896742944).The route now runs the same POST preamble as the bridge's other routes (
readPost,now(handlers)). No behaviour change: the same 405 and 400 messages, from the shared helper.pnpm typecheckclean;bridge-endpoints.test.ts20/20.🤖 automated · Fable 5, effort xhigh