Bug hunt: per-file analysis and individual fixes

[brillout]

Systematic bug hunt over every source file in the repository.

Process

• Each of the 550 source files got a sibling *.BUG-ANALYSIS.md documenting its business logic (high level), every function (low level), a thorough edge-case analysis of each, and the bugs found. The full notes live in this branch's history; the last commit reduces each doc to a single line recording when its file was last analysed and linking here.
• Each bug was verified against the code, its SPEC and its tests before being fixed, and each fix is its own commit with a regression test where the seam allowed one. Every fix commit's subject carries its own diff size as [+added,-removed], and its message states the bug twice — a one-line TL;DR and a full description.
• Fixes stay simple. Bugs whose fix would be complex and which are not critical were left alone.

Validation: pnpm typecheck clean; pnpm test green — 1588 node tests and 837 dashboard tests, 0 failures (7 tests added).

Scope note: "source file" here meant the JS/TS tree (.ts .tsx .mts .js .mjs .cjs). 34 files that could fairly be called source were not analysed: the 25 prompt markdown files under packages/framework/prompts/ (which compile into src/prompts.generated.ts), 3 GitHub Actions workflows, 3 CSS files, 2 HTML files and the Chrome extension's manifest.json.

Crashes and data-loss

• Claude driver / Codex driver: a stdout line of null is noise, not a crash. JSON.parse('null') succeeds, so the non-JSON catch never fired and the next field read threw — inside a readline handler, where nothing catches it. The daemon died of the uncaught exception and its exit hook SIGKILLed every live agent.
• RPC mount: parse the request path against a fixed base. The parse base was built from the request's own Host header, so Host: (empty — the fallback only covers absent) or Host: foo bar threw outside the handler's try, on a void-dispatched call. Any local process could end the daemon with one unanswered request.
• CI watch: an unreadable status is not an absence of checks. ghPrCiStatus answers none both for a repo with no CI and for a gh read that failed — its own contract says acting on an unreadable status must never merge anything. A timed-out or rate-limited read merged a watched PR with its real checks unseen.
• CI watch: a PR whose state is still being read is not an open PR. A warming cache answers pending behind a synthetic OPEN; the 150ms cold budget against a gh call meant the daemon's start-up tick saw that guess for every watched agent, re-merging landed PRs and able to start a fix session on a branch a human had closed.
• Archived meta patches go through the atomic write like every other. patchArchivedAgent truncated a meta in place while the history list polled it — the exact failure the rename-based write exists to prevent, and which its doc claims every write in the module uses.
• Closing keywords: defuse the colon form GitHub also accepts. GitHub's docs: "The keywords can be followed by colons... Closes: #10". Only whitespace was defused, so a plan agent writing Fixes: #1164 still closed the ticket its plan says is yet to be implemented — the incident this module exists to prevent.

Wrong behaviour

• Choice panel: a delivered pick counts as delivered. Both deliverers resolve void and the action hook reports failure as undefined, so the panel's success test never held in production: it re-enabled its buttons instead of parking, and the questions hub never collapsed an answered card.
• Unattended agents keep their messages, not just their Stop. The chat queue was gated on the gate switch, which unattended agents deliberately leave unset — so every message typed at a preset, routine or drain agent was shown as queued and then died unread, against both the SPEC and the comment above it.
• Open PR: decide against the PR that last saw the branch. The moved-past check ran against the first PR, so a session whose PR merged mid-run and kept committing read as unlanded and the button opened a third PR for work already in.
• Interventions: a parked agent is identified by which agent it is. Gate ids are unique only within an agent (every agent's first is await-choices), so two agents parked in one project shared an identity and only one was announced.
• Auto PM: a click that names a routine leaves the sweep's calendar alone. A named Run-now stamped the maintenance schedule although the sweep never ran, postponing it a whole interval.
• Tickets: a capitalised topic badge filters by its topic. Matching lowercases a ticket's topics and the URL parser lowercases what it reads, but click-to-filter added the badge verbatim — clicking UX emptied the page.
• Markdown tables / file diff counts / untracked file size / device hop draft cap / resume command quoting / scheme-less device pastes — see the individual commits.

Dashboard state

Per-agent latches that never reset on selection change (AgentView, AgentComposer, HandoffArm), a merged branch reporting "no changes", two sidebar destinations highlighted at once, and a missing dot on cloud-waiting rows.

Security

• File read: the .git guard matches the case the filesystem does. The guard matched .git exactly, but macOS and Windows resolve .GIT/config to the same file — and the path comes from the browser, on a config that holds a token after a gh clone.

---

Generated by Claude Code