The package lives at packages/framework: the project is The Framework, the package is one thing it contains (#1665) - #1670
Merged
Conversation
…, the package is one thing it contains (#1665) A directory move, nothing else: `git mv packages/the-framework packages/framework`, every SPEC.md moving beside its file. The npm name was already `framework`; the CLI (`the-framework`), the `.the-framework/` runtime directory, `the-framework.yml`, the repo URL and the website package `packages/the-framework.ai` keep their names. Path references rewritten: the root package.json scripts, .gitignore (prompts.generated.ts), the package's homepage + repository.directory, the pnpm-lock importer key (via pnpm install), the nesting example in daemon.test.ts, the chrome extension's jsdom resolve path in check.mjs, and the two SPEC lines naming the directory (root SPEC.md, packages/SPEC.md). Closes #1665
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 automated
Closes #1665 — Rom's ask on Discord: "Project === The Framework. Contains
framework(dashboard) + things like sdd.md. Sopackages/framework."What this is
A directory move, in one commit so
git log --followstays intact (checked:daemon.tsstill shows its 88 commits through the move):git mv packages/the-framework packages/framework. EverySPEC.mdmoves beside its file. 1112 files touched, 16 lines actually changed.The npm name was already
framework, so the published package does not change. What keeps its name: the CLI binarythe-framework, the.the-framework/runtime directory,the-framework.yml, the repo URLgithub.com/framework/the-framework, the rootpackage.json"name": "the-framework"(the monorepo is the project), and the website packagepackages/the-framework.ai.The path references rewritten
The issue's list, plus two it missed:
package.json— thebuild/preview/dev/typecheck/clean/testscripts.gitignore—packages/framework/src/prompts.generated.tsand its commentpackages/framework/package.json—homepage,repository.directorypnpm-lock.yaml— the workspace importer key, rewritten bypnpm install(that is the whole lockfile diff)src/daemon.test.ts:585,597— the nesting example (cosmetic)packages/chrome-extension/check.mjs:19resolvesjsdomfrom../the-framework→../framework(its check suite still passes)The workflows (
ci.yml,framework-agent.yml) never name the path — nothing to change there.SPEC.md changes
Two prose lines, both in the directory listings at the top of the tree. No business logic changes;
FEATURES-SPEC.mduntouched (not a feature).SPEC.md(root — "what does this software do" + how the top-level subsystems relate)packages/SPEC.md(the packages directory listing)Verified
Locally, the exact CI sequence at the new path:
pnpm install(offline, lockfile key only) →pnpm build→pnpm typecheck(both packages) →pnpm test— 1581 daemon tests + 803 dashboard tests, all green.After merge
Every clone:
git pullmoves the directory; a running daemon keeps serving from the moved inode but should be restarted frompackages/frameworkafter the nextpnpm build. Staledist-testunder the old path, if any, is just a leftover torm -rf.