fix(release): put @gemstack/the-framework back on the 1.x line - #1099
Merged
Conversation
The rename shipped with a major changeset, so the first release under the new name came out as 2.0.0. A rename to a NEW package name does not break anyone: @gemstack/framework keeps resolving and is deprecated with a pointer, so nothing installed stops working. Minor is the honest bump, and 1.x is the line we want to stay on. Sets the version to 1.2.0, moves the rename entry from Major to Minor Changes, rewords it so it no longer claims to be breaking, and fixes the CHANGELOG title, which still read @gemstack/framework. No changeset here on purpose: this corrects a version, it is not a change to publish, and a changeset would bump it straight back up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first release under the new package name went out as 2.0.0, because the rename carried a
majorchangeset (mine, in #1089). We want to stay on 1.x.Why minor is the right call
A rename to a new package name breaks nobody.
@gemstack/frameworkkeeps resolving exactly as before and gets deprecated with a pointer to the new name, so nothing installed today stops working. There is no break to signal, so major overstated it.What this changes
packages/the-framework/package.json:2.0.0→1.2.0(the old package sat at 1.1.0)# @gemstack/frameworkNo changeset in this PR on purpose. It corrects a version rather than shipping a change, and a changeset would bump it straight back up.
Note on npm state
@gemstack/the-framework@2.0.0is already published (public, and currentlylatestsince it is the only version). This PR only fixes the repo. Getting the registry onto 1.x needs three steps after merge, in this order:1.2.0npm dist-tag add @gemstack/the-framework@1.2.0 latest— required, because npm keepslateston the highest semvernpm unpublish @gemstack/the-framework@2.0.0(ornpm deprecateit)Step 3 must come after 1.2.0 exists: 2.0.0 is currently the only version, so unpublishing it first would remove the whole package and block republishing the name for 24 hours.
The
@gemstack/the-framework@2.0.0git tag and its GitHub Release also want removing.