refactor: rename packages/framework directory to packages/the-framework - #1092
Merged
Conversation
Align the directory name with the package (@gemstack/the-framework) and CLI (the-framework). Internal only, no published behavior change: package files resolve relative to the package dir, and the build scripts locate siblings via import.meta.url, so nothing depended on the old directory name. Updated the path references that did: repository.directory + homepage in package.json, the prompt-drift workflow's path filters and run step, .gitignore's generated-file path, the README package table, and an illustrative test path. Regenerated pnpm-lock.yaml.
suleimansh
marked this pull request as ready for review
July 23, 2026 19:56
This was referenced Jul 23, 2026
suleimansh
added a commit
that referenced
this pull request
Jul 28, 2026
…1337) #1311 untracked `.the-framework/control.jsonl` and added nothing to hold the line, so eighteen hours later a run's own branch committed an empty one straight back onto main (#1309). Tracking it is what #1298 is about: the daemon rewrites the control channel on every steer, so a tracked copy dirties every checkout and turns into delete-vs-modify conflicts between machines. Untracks it again, plus the copy under `packages/the-framework/` that a run executing inside the package directory left behind at the #1092 rename and that nothing has touched since. The guard is the point. The invariant is wider than one filename: `.the-framework/` is transient except the committed DB (#313/#857), so a tracked `run.json` or `events.jsonl` would churn a checkout exactly the same way. The new test asserts that every tracked path under a `.the-framework/` directory is one of the four committed kinds: the ignore file, LOGS.md, a conversation, or a user's session history. It skips itself outside a git checkout, so an installed package still tests. No changeset: nothing here ships in `dist`, so the published package is byte-identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final consistency pass on the rename: the directory now matches the package name (
@gemstack/the-framework) and CLI (the-framework).Internal only, no published behavior change. Package files resolve relative to the package dir, and the build scripts (
bundle-dashboard,gen-prompts,check-prompt-drift,run-tests) locate themselves and siblings viaimport.meta.url, so nothing depended on the literalpackages/frameworkpath.Changes
git mv packages/framework packages/the-framework(all files detected as pure renames)package.json:repository.directory+homepage.github/workflows/prompt-drift.yml: path filters + therunstep.gitignore: the generated-file pathREADME.md: package table link + label (framework->the-framework)daemon.test.tspnpm-lock.yaml(workspace glob ispackages/*, so no workspace-file change)Left alone
tickets/460-Vike_error.md@gemstack/framework-dashboard(boundary-safe replace never touched it)Verification
pnpm build12/12,pnpm typecheck22/22check-prompt-driftin sync (now resolving from the new path)Note: the move carried along a pre-existing tracked
.the-framework/control.jsonlruntime artifact that was already committed under the old dir. Happy to drop it from git in this PR if you'd like it untracked.