test(pdc-frontend): clear STRAPI_PUBLIC_URL in production CSP test to prevent http: leak from dev .env#1493
Open
AliKdhim87 wants to merge 1 commit into
Open
test(pdc-frontend): clear STRAPI_PUBLIC_URL in production CSP test to prevent http: leak from dev .env#1493AliKdhim87 wants to merge 1 commit into
AliKdhim87 wants to merge 1 commit into
Conversation
… prevent http: leak from dev .env
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Robbert
reviewed
Jun 16, 2026
| beforeEach(async () => { | ||
| process.env.OPEN_FORMS_API_URL = 'https://openforms.example.com'; | ||
| delete process.env.STRAPI_PUBLIC_URL; | ||
| jest.resetModules(); |
Member
There was a problem hiding this comment.
Kun je uitleggen wat het probleem is?
Collaborator
Author
There was a problem hiding this comment.
De jest.config.ts gebruikt nextJest, dat automatisch het .env-bestand inleest. Daardoor wordt STRAPI_PUBLIC_URL=http://localhost:1337/ toegevoegd aan de testomgeving.
De CSP-test voor productie laadt daarna opnieuw cspConfig.ts in, terwijl die HTTP-URL nog steeds is ingesteld. Die URL komt uiteindelijk terecht in frame-ancestors.
Dit is alleen lokaal een probleem. De test faalt omdat de productietest een https-URL verwacht, en geen http-URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.