Release 1.0.2: Fix production image workflow trigger - #49
Merged
Conversation
Production images were not building automatically because gh release create only fires a release event, not a push:tags event. Add release:published trigger so prod images build when releases are created by the automated workflow.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes production image workflow to trigger automatically when releases are created.
Why
The v1.0.1 release workflow created the release successfully, but the prod image workflow didn't trigger because
gh release createonly fires areleaseevent, not apush: tags:event. This is a known GitHub Actions limitation.Changes
release: publishedtrigger to prod-image.yamlpush: tags:as fallback for manual tag pushesTest plan