UX improvements: simpler passwords and visible narrator attribution - #43
Merged
Merged
Conversation
Change password generation from 4alphanumeric-word-word to word-word-2digits format (e.g. apple-banana-23 instead of 2a3f-apple-banana). Easier to read and type while maintaining reasonable entropy (1000 * 1000 * 100 = 100M combinations). Update test to verify words come from the wordlist and digits are numeric.
Move narrator name from password-gated section to book info header so it's visible immediately on the playback page, even when a password is required. This helps users know who recorded the book before unlocking it. Add test to verify narrator shows before password entry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
4alphanumeric-word-wordtoword-word-2digits(e.g.apple-banana-23instead of2a3f-apple-banana)Changes
Password simplification
Narrator attribution
Test plan