Repository navigation
fix: make game transfers recoverable and safer - #300
Merged
Merged
Conversation
Once a transfer is committed the destination is authoritative. A failed or refused removal of the old copy now finishes the transfer, deletes the journal row and reports the leftover folder as a warning, instead of blocking launch, uninstall and further transfers forever. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DGbCKVdcUfJfjZ93bYY9p3
A transfer recorded as copied always tried to commit, so a missing temporary copy (deleted, or its drive unplugged) blocked the game forever. Recovery now rolls back to the source when neither the copy nor the destination exists and the source is still owned and intact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DGbCKVdcUfJfjZ93bYY9p3
Transfer only refused a source that held another game's executable, so a game imported inside another game's folder could be moved out of it. Uninstall's overlap check (installation root, Steam path and executable, both directions) is now shared and applied to the transfer source and destination. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DGbCKVdcUfJfjZ93bYY9p3
transfer_game took a destination path from the webview and only checked that it was an absolute existing directory. It now takes a library id and resolves it with game_library::library_root, so games can only move into registered libraries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DGbCKVdcUfJfjZ93bYY9p3
This was referenced Nov 6, 2026
Paths that do not exist yet were compared uncanonicalized against canonical ones, so Windows short temp paths never matched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Four game transfer fixes from the review, one commit each:
copiedwith no temporary copy: recovery rolls back to the source when the temp copy and the destination are gone and the source is still owned (marker plus executable present).game_uninstall::overlaps_other_game(uninstall behaviour unchanged) and applied to both transfer source and destination.transfer_gametakes alibraryIdand only accepts a registered library, instead of an arbitrary path from the webview. Frontend callers already had the id.Intentionally left: if the destination can't be shown to be ours (e.g. drive unplugged), the transfer stays pending, because deleting the source then would be unsafe.
Validation
cargo test966 passed,cargo clippy --all-targets -D warningsandcargo fmt --checkclean.npm run check,npm run lint,npm run test:feedback,npm run test:aclpass.committed_transfer_unblocks_despite_leftover_source,leftover_source_is_reported,copied_transfer_without_copy_rolls_back,nested_game_paths_are_refused; frontend test checks the library id is sent.UI changes
New warning when the old copy can't be deleted after a transfer.
Generated by Claude Code