Conversation
added 7 commits
August 16, 2026 14:53
The old ci.yml lived under frontend/.github/workflows, which GitHub Actions never picks up since the repo root (with .git) is one level up — it was dead config. Moved a working version to .github/workflows at the repo root, split into a frontend job (npm ci, lint, typecheck, vitest, build) and a backend job (poetry install, black, pylint, pytest), mirroring the Dockerfile's own test stage. Also drops the stale yarn.lock now that npm/package-lock.json is what the project actually uses, and fixes .husky/commit-msg to call the locally installed commitlint binary directly instead of npx, which was trying (and failing) to fetch a package from the registry when git commit was run from the repo root instead of frontend/.
The root .gitignore had a bare "data/" pattern intended for a backend runtime data dir that doesn't actually exist in this project. Since gitignore patterns without a leading slash match at any depth, it also matched frontend/src/data/ — silently untracked, so navigation.ts only ever existed on disk locally. Worked in every local run (the file was right there) but broke on any fresh checkout, which is exactly what surfaced as "Cannot find module '../../data/navigation'" in CI.
setup-python's pip cache never got populated — pip is only used to install poetry itself (--no-cache-dir), all actual dependency downloads go through poetry's own cache. The post-job cache-save step failed because the pip cache dir it expected was never created. Caching by poetry.lock via setup-python's built-in poetry cache support actually speeds up poetry install instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.