chore(backend): remove unused Asp.Versioning.Mvc.ApiExplorer package - #496
Merged
Conversation
The package was declared in Directory.Packages.props and referenced in MyProject.WebApi.csproj but never used anywhere in the codebase - no AddApiVersioning() registration, no [ApiVersion] attributes, no ApiExplorer or IApiVersionDescriptionProvider wiring. API versioning is not configured, so the package contributed nothing to the build or the OpenAPI output. Removing it as dead code. Supersedes Dependabot PR #487 (which bumped this unused dependency 8.1.1 -> 10.0.0). Backend build and full test suite (1042 passed, 0 failed) verified green after removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
While reviewing the open Dependabot PRs, #487 proposed bumping
Asp.Versioning.Mvc.ApiExplorer8.1.1 -> 10.0.0 (a major bump carrying a breaking OpenAPI change: api-version params emitted asenuminstead ofdefault).Investigation found the package is dead code: declared in
Directory.Packages.propsand referenced inMyProject.WebApi.csproj, but never used anywhere -- noAddApiVersioning(), no[ApiVersion]attributes, noApiExplorer/IApiVersionDescriptionProviderwiring. API versioning is not configured, so the package contributes nothing to the build or the OpenAPI document.Rather than bump an unused dependency (and inherit its breaking change), this PR removes it.
Change
Asp.Versioning.Mvc.ApiExplorerfromDirectory.Packages.props<PackageReference>fromMyProject.WebApi.csprojTwo lines, purely subtractive.
Verification
dotnet build -c Release: 0 warnings, 0 errorsdotnet test -c Release: 1042 passed, 0 failed (Unit 97, Architecture 10, Component 541 +14 skipped, Api 394)Follow-up
Supersedes Dependabot #487, which will be closed in favour of this removal.
🤖 Generated with Claude Code