Fix plot_allocation's hardcoded PDF output and MB-only unit scaling#27
Merged
Conversation
fig.savefig always passed format="pdf" regardless of the requested file extension, so a .png path silently contained PDF bytes. And every axis tick, title, and limit annotation divided by MB unconditionally, so capacities below 1MB (small demo/test instances) rendered every y-tick as 0.0 and were unreadable. Let savefig infer the format from the path's own extension, and add _byte_unit/_format_bytes to pick B/KB/MB/GB per value instead of assuming MB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fig.savefig always passed format="pdf" regardless of the requested file
extension, so a .png path silently contained PDF bytes. And every axis tick,
title, and limit annotation divided by MB unconditionally, so capacities below
1MB (small demo/test instances) rendered every y-tick as 0.0 and were
unreadable.
Let savefig infer the format from the path's own extension, and add
_byte_unit/_format_bytes to pick B/KB/MB/GB per value instead of assuming MB.