Add Starkloupe interface - #4584
Merged
franciszekjob merged 6 commits intoSep 8, 2026
Merged
Conversation
maciektr
force-pushed
the
maciektr/starkloupe-interface
branch
from
September 2, 2026 11:19
3cf783f to
a4fe63b
Compare
maciektr
force-pushed
the
maciektr/starkloupe-interface
branch
from
September 3, 2026 22:07
a4fe63b to
e1c6612
Compare
maciektr
marked this pull request as ready for review
September 3, 2026 22:08
integraledelebesgue
approved these changes
Sep 4, 2026
integraledelebesgue
left a comment
integraledelebesgue
left a comment
Contributor
There was a problem hiding this comment.
Everything looks fine. Please remove the excessive LLM comments
- Drop the unused `StarkloupeEntryPointExecutionError` enum and alias - Drop the unneeded `Clone` derive on `CallSuccess` - Gate `CallInfoWithExecutionData::vm_trace`/`vm_memory` behind `starkloupe` - Rename `EntryPointExecutionErrorWithTraceAndMemory` fields to `vm_trace`/`vm_memory` for consistency - Inline the `relocated_memory`/`vm_artifacts` helpers in `execute_entry_point_call_cairo1` - Move the `// region: Modified blockifier code` marker to cover the changed run/relocate ordering in `cheatable_run_entry_point` - Reword or remove comments referring to "upstream" and "the fork" Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BoFbPCfbMSt52ngdyCAssf
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BoFbPCfbMSt52ngdyCAssf
Contributor
Author
|
@franciszekjob @integraledelebesgue Thanks, all changes done! |
franciszekjob
approved these changes
Sep 8, 2026
franciszekjob
enabled auto-merge (squash)
September 8, 2026 13:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.