Make Favorites page non static for desktop app - #67
Open
Will-Hellinger wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Favorites page just doesnt update/refresh.
This PR adds the following:
Live update for rating on song on favorites page
Favorited songs/albums now appear/disappear from the list instantly
Cover art fix (some songs never display artwork till they're played)
Live subsonic resync for global song rating
Active page reload on new page view (refetch)
Scrollable liked songs and albums
Rating shift to left to not cause realtime shift on global rating sync (image attached below)
Tested and confirmed working locally 👍