Android: change network security config to allow user certs - #66
Open
ketzelmania wants to merge 1 commit into
Open
Android: change network security config to allow user certs#66ketzelmania wants to merge 1 commit into
ketzelmania wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this app requires a self-hosted music server (obviously), I think it could be a common(?) issue (and was one that I ran into) that users will deploy a local certificate authority to allow secure connection to LAN services.
This change allows the app to access the user CA store on Android so HTTPS can be enforced on the server connection, even if the server only offers a locally-signed certificate.