GUI-6092 - Exit if blind scan is used with anything other than --path as a directory#15
Open
eduardghita wants to merge 1 commit into
Open
GUI-6092 - Exit if blind scan is used with anything other than --path as a directory#15eduardghita wants to merge 1 commit into
eduardghita wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a check to ensure that when --blind_scan is used, the provided --path argument refers to a directory.
- Resolves the real filesystem path for
args.path - Exits with an error message if
--blind_scanis combined with a non-directory path
Comments suppressed due to low confidence (1)
workbench-agent.py:1269
- Add a unit test for the case where
--blind_scanis used with a non-directory path to verify that this validation triggers the expected error.
if args.blind_scan and not os.path.isdir(real_path):
Comment on lines
+1270
to
+1271
| print("--path must be a directory when --blind_scan is used") | ||
| sys.exit(1) |
There was a problem hiding this comment.
Use parser.error(...) instead of print and sys.exit for argument validation so that the usage message is shown and error handling is consistent with other CLI errors.
Suggested change
| print("--path must be a directory when --blind_scan is used") | |
| sys.exit(1) | |
| parser.error("--path must be a directory when --blind_scan is used") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.