Skip to content

Bump fable from 5.5.0 to 5.6.0 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiksn merged 2 commits into from
Jul 6, 2026
Merged

Bump fable from 5.5.0 to 5.6.0 #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08aa4c0
Bump fable from 5.5.0 to 5.6.0
dependabot[bot] Jul 6, 2026
658436f
Handle null search params and format DateTimeOffset URLs
tiksn Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"fable": {
"version": "5.5.0",
"version": "5.6.0",
"commands": [
"fable"
],
Expand Down
5 changes: 3 additions & 2 deletions src/Bridge/Services/Clients/BranchClient.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ type BranchClient(transport: IHttpTransport) =
for id in ids do
yield "id", (id: UrlPart)
| _ -> ()
if not (String.IsNullOrEmpty(queryParams.search)) then
yield "search", (queryParams.search: UrlPart)
match Option.ofObj queryParams.search with
| Some search when not (String.IsNullOrEmpty(search)) -> yield "search", (search: UrlPart)
| _ -> ()
if queryParams.pageNumber.HasValue then
yield "pageNumber", (queryParams.pageNumber.Value: UrlPart)
if queryParams.pageSize.HasValue then
Expand Down
5 changes: 3 additions & 2 deletions src/Bridge/Services/Clients/DepartmentClient.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ type DepartmentClient(transport: IHttpTransport) =
for id in ids do
yield "id", (id: UrlPart)
| _ -> ()
if not (String.IsNullOrEmpty(queryParams.search)) then
yield "search", (queryParams.search: UrlPart)
match Option.ofObj queryParams.search with
| Some search when not (String.IsNullOrEmpty(search)) -> yield "search", (search: UrlPart)
| _ -> ()
if queryParams.pageNumber.HasValue then
yield "pageNumber", (queryParams.pageNumber.Value: UrlPart)
if queryParams.pageSize.HasValue then
Expand Down
10 changes: 6 additions & 4 deletions src/Bridge/Services/Clients/EmployeeClient.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ type EmployeeClient(transport: IHttpTransport) =
for id in ids do
yield "id", (id: UrlPart)
| _ -> ()
if not (String.IsNullOrEmpty(queryParams.search)) then
yield "search", (queryParams.search: UrlPart)
match Option.ofObj queryParams.search with
| Some search when not (String.IsNullOrEmpty(search)) -> yield "search", (search: UrlPart)
| _ -> ()
if queryParams.pageNumber.HasValue then
yield "pageNumber", (queryParams.pageNumber.Value: UrlPart)
if queryParams.pageSize.HasValue then
Expand All @@ -33,8 +34,9 @@ type EmployeeClient(transport: IHttpTransport) =

let buildPagingUrl (queryParams: EmployeePagingRequestModel) =
let parameters =
[ if not (String.IsNullOrEmpty(queryParams.search)) then
yield "search", (queryParams.search: UrlPart)
[ match Option.ofObj queryParams.search with
| Some search when not (String.IsNullOrEmpty(search)) -> yield "search", (search: UrlPart)
| _ -> ()
if queryParams.pageNumber.HasValue then
yield "pageNumber", (queryParams.pageNumber.Value: UrlPart)
if queryParams.pageSize.HasValue then
Expand Down
4 changes: 3 additions & 1 deletion src/Bridge/Services/UrlHelpers.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ module Fossa.Bridge.Services.UrlHelpers


open System
open System.Globalization

let private suffixMappings =
[ ".dev.localhost:4211", ".dev.localhost:5210"
Expand Down Expand Up @@ -39,7 +40,8 @@ type UrlPart(value: string) =

static member op_Implicit(dt: DateTime) = UrlPart(string dt)

static member op_Implicit(dto: DateTimeOffset) = UrlPart(string dto)
static member op_Implicit(dto: DateTimeOffset) =
UrlPart(dto.ToString("O", CultureInfo.InvariantCulture))

let composeRelativeUrl
(endpointUrl: string)
Expand Down
Loading