feat(api): return 426 for unknown socket API routes#124
Open
LaurenceJJones wants to merge 1 commit into
Open
Conversation
Add a catch-all handler so clients can detect a stale Olm daemon after CLI upgrade instead of ambiguous Go 404 responses (fosrl/pangolin#3092).
LaurenceJJones
requested review from
miloschwartz and
oschwartz10612
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Add a catch-all handler so clients can detect a stale Olm daemon after CLI upgrade instead of ambiguous Go 404 responses (fosrl/pangolin#3092).
How to test?
When a newer client interacts with the olm socket api it will be returned status
426"upgrade required" which we will inform the clients that they need to restart the tunnel connection. This is a edge case found in fosrl/pangolin#3092 but we shouldnt rely on status404since that is vauge (could be a legit status code that we want EG: ssh into a resource, resource not found?) and olm should return a distinct code for catch all routes.