Skip to content

fix(auth): suppress browser output during login #25 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huda-code wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(auth): suppress browser output during login #25 #98

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9699a41
fix(auth): suppress browser output during login
huda-code Jun 25, 2026
ba26b0c
fix(auth): suppress browser output during login
huda-code Jun 29, 2026
ade9616
Remove output suppression for browser opening
huda-code Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions cmd/auth/login/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"bufio"
"errors"
"fmt"
"io"
"os"
"strings"
"time"
Expand Down Expand Up @@ -33,6 +34,21 @@ func getDeviceName() string {
return hostname
}

func openBrowserQuietly(url string) error {
stdout := browser.Stdout
stderr := browser.Stderr

browser.Stdout = io.Discard
browser.Stderr = io.Discard

defer func() {
browser.Stdout = stdout
browser.Stderr = stderr
}()

return browser.OpenURL(url)
}

func loginWithWeb(hostname string) (string, error) {
// Build base URL for login (use hostname as-is, StartDeviceWebAuth will add /api/v1)
baseURL := hostname
Expand Down Expand Up @@ -81,7 +97,7 @@ func loginWithWeb(hostname string) (string, error) {
_, err := reader.ReadString('\n')
if err == nil {
// User pressed Enter, open browser
if err := browser.OpenURL(loginURL); err != nil {
if err := openBrowserQuietly(loginURL); err != nil {
// Don't fail if browser can't be opened, just warn
logger.Warning("Failed to open browser automatically")
logger.Info("Please manually visit: %s", baseLoginURL)
Expand Down Expand Up @@ -328,11 +344,11 @@ func loginMain(cmd *cobra.Command, opts *LoginCmdOpts) error {
} else if apiServerInfo != nil {
// Convert api.ServerInfo to config.ServerInfo
serverInfo := &config.ServerInfo{
Version: apiServerInfo.Version,
SupporterStatusValid: apiServerInfo.SupporterStatusValid,
Build: apiServerInfo.Build,
EnterpriseLicenseValid: apiServerInfo.EnterpriseLicenseValid,
EnterpriseLicenseType: apiServerInfo.EnterpriseLicenseType,
Version: apiServerInfo.Version,
SupporterStatusValid: apiServerInfo.SupporterStatusValid,
Build: apiServerInfo.Build,
EnterpriseLicenseValid: apiServerInfo.EnterpriseLicenseValid,
EnterpriseLicenseType: apiServerInfo.EnterpriseLicenseType,
}
// Update account with server info
account := accountStore.Accounts[user.UserID]
Expand Down