Improve ELF note support - #50
Merged
Merged
Conversation
Match the naming convention used in elf.h (e.g., ELF_NOTE_SOLARIS, ELF_NOTE_GNU, and ELF_NOTE_FDO). This also makes the constants unambiguous when used as static imports.
The note name is stored with trailing null bytes stripped, so that, e.g., "Go\0" and "Go\0\0" both become "Go". Expose the raw name size so that callers can distinguish between them (Go notes have a name size of 4).
Add notes() for parsing note entries in PT_NOTE segments which delegates to ElfNoteSection.readNotes(). This enables note access when section headers are stripped.
Contributor
Author
|
@fornwall This should be the last pull request. I split it as three commits since I modified the ELF note constants again and didn't want to wait for that to be merged. Thanks! |
Contributor
Author
|
@fornwall Maybe I should add |
Contributor
Author
|
@fornwall sorry to ping you, but I finished all my pull requests and you seemed to disappear right as I finished. Thanks! |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.