fix(gateway): map OTLP mode to valid protocol for Caddy

[sofiasimdianova]

No description provided.

[coderabbitai]

Warning

Review limit reached

@sofiasimdianova, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 24 minutes and 31 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 510a6ee4-da94-4f4d-8d3e-beb838e93af4

📥 Commits

Reviewing files that changed from the base of the PR and between 79419c3 and 2c9d454.

⛔ Files ignored due to path filters (3)

• tests/e2e/chainsaw/09-observability/chainsaw-test.yaml is excluded by !**/*.yaml
• tests/e2e/chainsaw/09-observability/resources/otelexporterendpoint.yaml is excluded by !**/*.yaml
• tests/e2e/chainsaw/09-observability/resources/stack.yaml is excluded by !**/*.yaml

📒 Files selected for processing (1)

• internal/resources/caddy/caddy.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/otlp-protocol-mapping

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[NumaryBot]

🛑 Changes requested — automated review

The code change leaves an existing e2e test assertion expecting the previous protocol value, so the repository's test suite can fail even though the runtime mapping may be intended.

[NumaryBot]

🛑 Changes requested — automated review

The new protocol mapping fixes the basic HTTP mode case, but pathful HTTP OTLP DSNs that already include the traces endpoint are malformed by the added suffix logic.

[NumaryBot]

🛑 Changes requested — automated review

The protocol mapping is mostly correct, but the new endpoint rewriting breaks supported OTLP DSNs that already specify a custom/full trace path.

[NumaryBot]

🛑 Changes requested — automated review

The protocol mapping is mostly correct, but base HTTP endpoints with a trailing slash are routed to the wrong path and will fail to export traces through Caddy.

[NumaryBot]

🛑 Changes requested — automated review

The new protocol mapping generally addresses the intended Caddy value, but it mishandles full HTTP endpoints that include a trailing slash by generating a double-slash OTLP traces path.

[NumaryBot]

🛑 Changes requested — automated review

The new e2e step expects the gateway deployment to update after only an OtelExporterEndpoint is applied, but no gateway reconcile is triggered by that resource, so the test will time out.

[NumaryBot]

✅ Approve — automated review

No discrete correctness issues were identified in the changed code. The OTLP mode mapping and endpoint path handling appear consistent with the intended Caddy/OpenTelemetry protocol values.

No findings.

[NumaryBot]

✅ Approve — automated review

The OTLP protocol mapping and endpoint path handling appear consistent with the existing environment variable generation and the added test coverage. I did not find any discrete regressions introduced by this patch.

No findings.