feat(regions,formance): wire global.monitoring.support by sofiasimdianova · Pull Request #391 · formancehq/helm

sofiasimdianova · 2026-06-25T09:57:51Z

No description provided.

coderabbitai · 2026-06-25T09:58:01Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 14ea6814-d2a3-451c-83a5-c215069ffac1

📥 Commits

Reviewing files that changed from the base of the PR and between a09a235 and a629547.

⛔ Files ignored due to path filters (12)

charts/console-v3/Chart.lock is excluded by !**/*.lock, !**/*.lock
charts/formance/Chart.lock is excluded by !**/*.lock, !**/*.lock
charts/formance/Chart.yaml is excluded by !**/*.yaml
charts/formance/values.schema.json is excluded by !**/*.json
charts/formance/values.yaml is excluded by !**/*.yaml
charts/membership/Chart.lock is excluded by !**/*.lock, !**/*.lock
charts/portal/Chart.lock is excluded by !**/*.lock, !**/*.lock
charts/regions/Chart.lock is excluded by !**/*.lock, !**/*.lock
charts/regions/Chart.yaml is excluded by !**/*.yaml
charts/regions/templates/stack.yaml is excluded by !**/*.yaml
charts/regions/values.schema.json is excluded by !**/*.json
charts/regions/values.yaml is excluded by !**/*.yaml

📒 Files selected for processing (3)

README.md
charts/formance/README.md
charts/regions/README.md

✅ Files skipped from review due to trivial changes (2)

charts/formance/README.md
charts/regions/README.md

Walkthrough

The root Helm chart table and both chart README badges were updated to new Formance and Regions versions. The Formance and Regions READMEs also document global.monitoring.support settings for support telemetry forwarding.

Changes

Helm README updates

Layer / File(s)	Summary
Version references `README.md`, `charts/formance/README.md`, `charts/regions/README.md`	The root Helm chart table and both chart README version badges now reference Formance 1.15.0 and Regions 3.12.0.
Support telemetry documentation `charts/formance/README.md`, `charts/regions/README.md`	The Formance values docs add `global.monitoring.support`, and the Regions README adds a monitoring configuration section for the same support fields.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

formancehq/helm#360: Updates Helm chart version entries in the root README.md and charts/formance/README.md, matching part of the version-reference change here.
formancehq/helm#376: Modifies charts/regions/README.md’s Regions chart version documentation, overlapping with the Regions version bump here.
formancehq/helm#375: Touches Helm chart documentation version badges and also adds global.monitoring.support documentation like this PR.

Suggested labels: bug

Suggested reviewers: flemzord, sylr

Poem

A rabbit hopped through charted lore,
New versions bounced from shore to shore.
Support fields sprouted, neat and bright,
For monitoring carrots in the night.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No meaningful description was provided, so the check can't confirm how the changes relate to the PR.	Add a short summary of the chart and README changes, especially the new global.monitoring.support configuration and version bumps.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the main change by describing the new global.monitoring.support wiring for regions and formance.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/monitoring-support-chain

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

NumaryBot

🛑 Changes requested — automated review

The new support monitoring defaults can leave the opt-in feature inert for chart-created stacks because the default selector does not match labels emitted by the chart.

NumaryBot

🛑 Changes requested — automated review

The new stack label can make otherwise valid stack names render invalid Kubernetes resources. This should be fixed before considering the patch correct.

NumaryBot

✅ Approve — automated review

The changes add the new monitoring support values through the formance and regions charts and add the stack label needed for selection. I did not find a discrete regression in the modified files.

No findings.

flemzord · 2026-06-26T08:33:13Z

+    support:
+      # -- Enable Formance support telemetry forwarding (opt-in)
+      # @section -- Monitoring configuration
+      enabled: false


Thanks for the extra context that the operator chart already has the support template on 3.11.3-dev and that global.* values propagate into the operator subchart automatically. The remaining issue is the release/lock coupling: this branch renders with operator 3.11.2, where that template is absent, so global.monitoring.support.enabled=true is still a no-op for anyone installing this chart before the next operator release. Please either bump/lock the operator dependency to a released version that contains the OTLP support template before merging, or document the minimum operator release/sequence so users do not enable a non-functional option.

NumaryBot · 2026-06-30T08:59:29Z

✅ Approve — automated review

The PR wires global.monitoring.support into the regions and formance charts, adds a stack label with truncation, and updates lockfiles. All previously raised major issues have been addressed or dismissed by the author: the stackSelector mismatch was reported as fixed, the stack label truncation was fixed with suffix trimming, the operator version dependency concern was documented, and the lockfile updates for console-v3/membership/portal are auto-generated by the pre-commit hook and cannot be reverted without failing CI. No new issues were identified by the independent reviewer. Nothing remains that warrants blocking the merge.

No findings.

NumaryBot

NumaryBot posted 3 new inline findings.

Summary: #391 (comment)

NumaryBot

NumaryBot posted 3 new inline findings.

Summary: #391 (comment)

NumaryBot

NumaryBot posted 1 new inline finding.

Summary: #391 (comment)

NumaryBot

NumaryBot posted 4 new inline findings.

Summary: #391 (comment)

…bution chain

NumaryBot

NumaryBot review complete: no remaining inline findings.

Resolved 3 stale NumaryBot review threads (3 fixed, 0 outdated).

Summary: #391 (comment)

github-actions Bot added docs feature release labels Jun 25, 2026

sofiasimdianova force-pushed the feat/monitoring-support-chain branch from 64b34d2 to 0949b7b Compare June 25, 2026 10:28

sofiasimdianova marked this pull request as ready for review June 25, 2026 14:33

sofiasimdianova requested a review from a team as a code owner June 25, 2026 14:33

NumaryBot reviewed Jun 25, 2026

View reviewed changes

Comment thread charts/regions/values.yaml

sofiasimdianova force-pushed the feat/monitoring-support-chain branch from 0949b7b to 35bf4ae Compare June 25, 2026 16:06

NumaryBot reviewed Jun 25, 2026

View reviewed changes

Comment thread charts/regions/templates/stack.yaml Outdated

sofiasimdianova force-pushed the feat/monitoring-support-chain branch from 35bf4ae to 0a9a454 Compare June 25, 2026 16:32

NumaryBot reviewed Jun 25, 2026

View reviewed changes

flemzord reviewed Jun 26, 2026

View reviewed changes

sofiasimdianova force-pushed the feat/monitoring-support-chain branch from 0a9a454 to a09a235 Compare June 30, 2026 08:57

NumaryBot reviewed Jun 30, 2026

View reviewed changes

Comment thread charts/regions/templates/stack.yaml Outdated

Comment thread charts/regions/values.yaml

Comment thread charts/regions/values.yaml

sofiasimdianova force-pushed the feat/monitoring-support-chain branch from a09a235 to a0466e7 Compare June 30, 2026 09:39

NumaryBot reviewed Jun 30, 2026

View reviewed changes

Comment thread charts/regions/templates/stack.yaml

Comment thread charts/regions/values.yaml

Comment thread charts/console-v3/Chart.lock Outdated

sofiasimdianova force-pushed the feat/monitoring-support-chain branch from a0466e7 to ed72201 Compare June 30, 2026 09:46

NumaryBot reviewed Jun 30, 2026

View reviewed changes

Comment thread charts/regions/values.yaml

sofiasimdianova force-pushed the feat/monitoring-support-chain branch from ed72201 to 282927e Compare June 30, 2026 09:54

NumaryBot reviewed Jun 30, 2026

View reviewed changes

Comment thread charts/regions/values.yaml

Comment thread charts/regions/values.yaml

Comment thread charts/regions/templates/stack.yaml

Comment thread charts/console-v3/Chart.lock

feat(regions,formance): wire global.monitoring.support through distri…

a629547

…bution chain

sofiasimdianova force-pushed the feat/monitoring-support-chain branch from 282927e to a629547 Compare July 2, 2026 14:15

NumaryBot reviewed Jul 2, 2026

View reviewed changes

sofiasimdianova requested a review from flemzord July 2, 2026 14:24

Uh oh!

Conversation

sofiasimdianova commented Jun 25, 2026

Uh oh!

coderabbitai Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 inconclusive)

Uh oh!

NumaryBot left a comment

Choose a reason for hiding this comment

🛑 Changes requested — automated review

Uh oh!

Uh oh!

NumaryBot left a comment

Choose a reason for hiding this comment

🛑 Changes requested — automated review

Uh oh!

Uh oh!

NumaryBot left a comment

Choose a reason for hiding this comment

✅ Approve — automated review

Uh oh!

flemzord Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NumaryBot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Approve — automated review

Uh oh!

NumaryBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NumaryBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NumaryBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NumaryBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NumaryBot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Jun 25, 2026 •

edited

Loading

flemzord Jun 26, 2026 •

edited

Loading

NumaryBot commented Jun 30, 2026 •

edited

Loading