Repository navigation
Pack hone review units to ~400 lines; re-review only units not yet done (IMP-1) - #35
Merged
Merged
Conversation
… done (IMP-1) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMP-1 from the Antigravity review.
Before: hone reviewed one unit per task, and every round re-ran the full panel on every task, including tasks that had already had two clean reviews and that no fix touched.
Now (
skills/hone/SKILL.md, Review Units and Convergence):quench-log.mdorder, are packed into review units of at most ~400 changed lines. A single task over the budget is still split by commit and logged as anvil feedback. The units are listed at the top ofcode-review.md.- Rating:line, the lowest unit rating (a done unit counts as A++). Smithy's state machine, the example gate table and CI all read that line, so nothing downstream changes. The 3-round cap is unchanged.Worked example (
examples/…/code-review.md) updated, with the same ratings (C → A+ → A++). Units are U1 = T001+T002 (246), U2 = T003–T005 (393) and U3 = T006 (127). Round 1's fix touchesrouter.py, which U3 also changes, so U3 is re-opened. With U1's carried UNCONFIRMED check, all three units are reviewed in every round. The example shows the rules applied honestly rather than a saving: here the panel goes from 6 per round to 3 per round (9 critic reports instead of 18). The review's "-61%" estimate was a hypothetical and isn't claimed.quench's log description is updated to match. Hone stays at 257 lines. Local: lint, sphinx zero warnings, smoke, dogfood, eval 100.00, example trail check.Together with #33, this changes the hone contract, so the next release is 0.2.0.
🤖 Generated with Claude Code