Skip to content

fix #33#34

Open
enbyted wants to merge 1 commit into
foreversd:masterfrom
enbyted:patch-1
Open

fix #33#34
enbyted wants to merge 1 commit into
foreversd:masterfrom
enbyted:patch-1

Conversation

@enbyted

@enbyted enbyted commented Feb 1, 2015

Copy link
Copy Markdown

Reconnect logic is now disabled when disconnect is by request (call to .end() or .destroy()).
This is not tested though, I don't have time for that. I may have missed some place where reconnect logic should be enabled back ( .retry.closed set to false ).

Reconnection logic is now disabled when disconnect is by request (call to .end() or .destroy()).
@indexzero

Copy link
Copy Markdown
Member

Would be accepted with tests. Otherwise will wait until someone with commit access has the time to write tests, which could be several months.

@enbyted

enbyted commented Feb 2, 2015

Copy link
Copy Markdown
Author

Well for me it could also be several months, when I'd have some time I'll
look into it, but no promises there.

Pozdrawiam
Bartosz Grabias
+48 793669953

2015-02-02 18:15 GMT+01:00 Charlie Robbins notifications@github.com:

Would be accepted with tests. Otherwise will wait until someone with
commit access has the time to write tests, which could be several months.


Reply to this email directly or view it on GitHub
#34 (comment).

@AlmirKadric

Copy link
Copy Markdown

This PR doesn't completely solve the issue. In the case where the retry timeout has already been created, this will still end up throwing. I have a PR coming soon which will fix this issue and a bunch of others I found getting nssocket ready for my own use.

EDIT: Take a look at #41

@andrew-aladev

andrew-aladev commented Oct 10, 2016

Copy link
Copy Markdown

@AlmirKadric +1

We should guard both prototype.reconnect and tryReconnect with this.retry.closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants