fix(ci): restore iOS 26 test leg by guarding empty matrix.macos at call site#476
Merged
Merged
Conversation
…ll site
When a matrix include entry omits `macos`, `${{ matrix.macos }}` evaluates
to an empty string which, when passed as a workflow_call input, overrides
the reusable workflow's `default: macos-latest` — causing `runs-on: ""`
and silently producing no job for that leg.
Fix by adding `|| 'macos-latest'` at the call site in both pr.yaml and
nightly.yaml, so any matrix row that omits `macos` automatically gets the
right runner without requiring explicit per-row bookkeeping.
Credit to @james-enperso for identifying the regression and confirming it
against the live GitHub jobs API (PR forcedotcom#474).
1 task
|
||||||||||||||
bbirman
approved these changes
Jul 7, 2026
brandonpage
reviewed
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a matrix
includeentry omitsmacos,${{ matrix.macos }}evaluates to an empty string. When passed as aworkflow_callinput, an empty string overrides the reusable workflow'sdefault: macos-latest— leavingruns-on: "", which causes GitHub to silently produce no job for that matrix leg. The iOS 26 / Xcode 26 leg has been silently absent from every PR and nightly run since the matrix was restructured.Credit to @james-enperso for identifying the regression and confirming it against the live GitHub jobs API (PR #474).
Root cause
The issue is at the call site, not in the matrix.
${{ matrix.macos }}passes an explicit empty string, which GitHub Actions does not treat as "not supplied" — so thedefault:inreusable-workflow.yamlnever fires.Fix
Add
|| 'macos-latest'at the call site in bothpr.yamlandnightly.yaml:This means:
macosexplicitly (e.g.macos: macos-15on the^18leg) passes that value through unchanged.macos(e.g. the^26leg) automatically getsmacos-latest— no per-row bookkeeping required.macos-latestremains the single source of truth inreusable-workflow.yaml; future matrix additions won't silently skip if they forget to setmacos.Why not add
macos: macos-latestto the^26include entry?That approach (taken in PR #474) works for today's matrix but duplicates the default string across three files and leaves the codebase one forgotten entry away from the same silent-skip bug recurring. The call-site fallback is self-enforcing.
Test plan
^26job again (4 jobs total:permission-check+android-pr+ios-pr (^26)+ios-pr (^18)).ios-pr (^18)still runs onmacos-15(the explicit override is preserved).🤖 Generated with Claude Code