fix(net): join array fieldlist in net.retrieve so the documented usage works

[james-enperso]

Problem

net.retrieve's public, typed, and documented signature takes fieldlist: string[]:

retrieve('Contact', id, ['FirstName', 'LastName'], onSuccess, onError)

…but the array was passed straight through to the native bridge as the fields query param:

const fields = fieldlist ? { fields: fieldlist } : null;

On Android the array is URL-encoded as its Java ArrayList.toString() → fields=%5BFirstName%2C+LastName%5D (i.e. fields=[FirstName, LastName]), which Salesforce rejects with INVALID_FIELD / 400; iOS can't produce a valid comma-joined value from an NSArray either. So the documented/typed usage deterministically fails, and the only form that works — a pre-joined string — contradicts the TypeScript signature. The shared net.test.js only ever passes a pre-joined string, so the typed path was never exercised.

Fix

Join the array before it crosses the bridge; a string is passed through unchanged for the legacy pre-joined caller:

const fields = fieldlist
  ? { fields: Array.isArray(fieldlist) ? fieldlist.join(",") : fieldlist }
  : null;

Note on dist/ and the build

main points at dist/index.js, so the fix must ship in dist/ too. However, npm run build (tsc --build) extends @react-native/typescript-config, which sets noEmit: true — so it type-checks only and does not regenerate dist/. The committed dist/ is CommonJS produced by a separate release-time config; a naive tsc would re-emit the tree as ESM and break the package. So dist/react.force.net.js is hand-synced here to mirror the compiled src change (the .d.ts is unchanged — the signature is the same). Flagging the noEmit build discrepancy for a maintainer to look at separately; a maintainer may prefer to regenerate dist/ with the real release tooling.

Test plan

• Add a shared-suite assertion that calls net.retrieve with a string[] fieldlist (currently only the pre-joined-string form is tested).
• Verify a retrieve with ['FirstName','LastName'] returns the fields on both platforms.

🤖 Generated with Claude Code

https://claude.ai/code/session_015CGbVaRKrx7DeurX81NWdQ

[wmathurin]

Hi @james-enperso — thank you for this! The bug diagnosis is spot-on, and flagging the noEmit build discrepancy was exactly the right call.

We're closing this in favour of #477, which fixes the same retrieve bug but also properly resolves the dist/ generation problem you identified rather than hand-syncing:

• tsconfig.build.json — a new config that overrides noEmit: false / module: commonjs / moduleResolution: node, so dist/ can be regenerated reproducibly with tsc --project tsconfig.build.json by anyone.
• setversion.sh — updated to call that config at release time, so the release process never needs a hand-edited dist/ again.
• The dist/ in fix(net): join array fieldlist in net.retrieve so the documented usage works #477 was generated by the compiler, not written by hand.

Your contribution is credited in the commit message. Thanks again for the thorough write-up!