Skip to content

@W-23431930: [Android] Update sf__app_blocked_error string to reference Salesforce admin#2964

Merged
JohnsonEricAtSalesforce merged 1 commit into
forcedotcom:devfrom
JohnsonEricAtSalesforce:feature/W-23431930_android-update-sf-app-blocked-error-string-to-reference-salesforce-admin
Jul 14, 2026
Merged

@W-23431930: [Android] Update sf__app_blocked_error string to reference Salesforce admin#2964
JohnsonEricAtSalesforce merged 1 commit into
forcedotcom:devfrom
JohnsonEricAtSalesforce:feature/W-23431930_android-update-sf-app-blocked-error-string-to-reference-salesforce-admin

Conversation

@JohnsonEricAtSalesforce

Copy link
Copy Markdown
Contributor

Summary

Updates the user-facing localized string sf__app_blocked_error to direct users to their Salesforce admin instead of generic support.

Before: This app could not be verified. Contact support.
After: The app couldn't be verified. Contact your Salesforce admin.

This string is displayed as a toast in LoginActivity.onAuthFlowError() when OAuth code exchange fails with a client-blocked error (APP_ATTESTATION_FAILED / APP_ATTESTATION_FAILED_RETRY).

⚠️ Localization callout (human review required)

  • This changes an sf__ string in libs/SalesforceSDK/res/values/sf__strings.xml. Per repo CLAUDE.md, sf__ string changes require human review.
  • The string exists only in the base values/ locale — there are no translated copies to update.
  • The apostrophe is backslash-escaped (couldn\'t) as required by the Android resource compiler; it renders as a straight ASCII apostrophe at runtime.

Platform consistency

The app-attestation / client-blocked flow is Android-only; the iOS SDK has no equivalent string, so no iOS counterpart PR is needed.

Test plan

  • :libs:SalesforceSDK:assembleDebug builds successfully with the escaped apostrophe.
  • No test asserts the literal toast text (the flow has no such coverage today), so none required updating.

This response was generated by an AI agent on behalf of @JohnsonEricAtSalesforce.

…ce Salesforce admin (Reword app-blocked toast to direct users to their Salesforce admin)

@sfdctaka sfdctaka left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohnsonEricAtSalesforce
JohnsonEricAtSalesforce merged commit cc4d3bb into forcedotcom:dev Jul 14, 2026
4 of 5 checks passed
@JohnsonEricAtSalesforce
JohnsonEricAtSalesforce deleted the feature/W-23431930_android-update-sf-app-blocked-error-string-to-reference-salesforce-admin branch July 14, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants