Skip to content

feat: modernize otel - #316

Merged
franklinkim merged 9 commits into
mainfrom
feature/otel
Oct 7, 2026
Merged

franklinkim merged 9 commits into
mainfrom
feature/otel

Conversation

@franklinkim

Copy link
Copy Markdown
Member

Description

Modernize OpenTelemetry integration by adopting semconv attributes for logs, traces, and metrics. Bump OTel and semconv dependencies, use upstream semconv conventions where available, and consolidate keel-specific attributes in semconv/ package.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 📝 Documentation
  • ♻️ Refactoring
  • 🏃‍➡️ Performance
  • ✅ Tests
  • 🔐 Security
  • 🔧 Build/CI

Changes

  • Bump go.opentelemetry.io/otel to v1.43.0, update all semconv versions
  • Replace legacy log fields with go.opentelemetry.io/otel/semconv attributes in log.With* functions
  • Add new semconv packages: generic.go (name, value, duration, trace/span IDs), circuitbreaker.go, rbac.go
  • Migrate log field setters to use WithAttributes and OTel attributes
  • Update HTTP middleware and roundtripware to use semconv attributes
  • Fix deprecation warnings and update GitHub Actions cache key
  • Add integration tests for NATS connect logging
  • Apply semconv to job, closer, temporal metrics, and stream implementations

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.

@danielthomas74 danielthomas74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mini-comment

Comment thread examples/telemetry/main.go Outdated
@franklinkim
franklinkim merged commit f8e4bd3 into main Oct 7, 2026
4 checks passed
@franklinkim
franklinkim deleted the feature/otel branch October 7, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants