Skip to content

fix: correct documentation checker edge cases - #39

Merged
fnayou merged 4 commits into
mainfrom
fix/docs-checker-edge-cases
Oct 25, 2026
Merged

fnayou merged 4 commits into
mainfrom
fix/docs-checker-edge-cases

Conversation

@fnayou

@fnayou fnayou commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Summary

 check_site
+  reject root-absolute links outside the GitHub Pages base path
+  accept controls wrapped by an implicit <label>
+CONTRIBUTING.md
+  state the Python 3.11+ requirement for tomllib

Adds regressions for the Pages subpath and implicit-label cases. Documents the checker’s Python minimum.

Closes #34

Evidence

  • Before: / and /assets/site.css could pass against existing root files even when Pages serves the site under /ffmpegfyMe; a wrapped input without an id failed accessibility checks.
  • After: 10 checker tests pass. Strict Zensical build and generated-site checks pass for 8 pages. task docs:check passes.

Merge Danger

Door: Two-way

Blast Radius: Docs

Revert the PR to restore the previous checker behavior and contributor guidance.

@fnayou
fnayou merged commit 14f8cc3 into main Oct 25, 2026
3 checks passed
@fnayou
fnayou deleted the fix/docs-checker-edge-cases branch October 25, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation build and quality checks

1 participant