Multiple icon/note changes, and more

[hugo9655]

Changes:

Icons & Note Changes: (preview 1, preview 2)

• Improved contrast and visibility of icons:
  • Added separate icon for warning messages (colored amber as they're typically important).
  • Note icon colors are now using a softer tint of the hyperlink color.
• Note Changes:
  • Minor formatting/wording clarifications and corrections across many notes.
  • Added a handful of new notes and warnings.
  • Transferred remaining notes to the internal notes system.

Misc:

• Multiple linting and formatting corrections, and tag adjustments across pages.
• Excluded admonitions and /posts/ directory from linting check 9, as they can have wildly different wording.
• Changed web platform tooltip text to Web-Based.
• Removed duplicate SoftArchive mirror links.
• Added warning admonition under Shopping > Games regarding unauthorized key resellers.
• Replaced all imgur image links with a file host accessible to UK visitors (whom make up a large portion of FMHYs traffic).

[nbats]

Theres just so much here that was NEVER discussed...

• You're removing working imgur links, not discussed.
• You're adding a new color icon for warning, not discussed.
• You're adding random notes to the top of sections, not discussed.
• You switched all phone # to phone no. which we did discuss in past and decide against already.

This is why I hate when people do this... some of your changes are prob good, but when you bury them in hundreds at once the odds I can merge this are like 0%.

[nbats]

I think making the warning icon a color or "dangerous" looking symbol could make a lot of people think its a "unsafe" tag which isn't true. I don't want people thinking FMHY is posting unsafe stuff and just "tagging" them.

This is why we have a discord with a suggestion and to-do channel... so these things can be discussed before someone goes through the effort.

[nbats]

I guess splitting it could probably help, your formatting changes + note.md changes I think are all fine so you could just send those in their own PR.

• Undo warning icon stuff, I appreciate the effort but I really think it gives a bad impression that the things are outright unsafe
• Use imgur links as backups rather than delete them, its good to keep backups and it works in most places still
• Adding the new sanet mirror site is fine, but I think its still smart for us to keep some of their backups listed ourselves in case the mirror site itself goes down
• Undo the phone # stuff, iirc there was a suggestion thread about this a few months ago and we decided against it
• For any notes we're putting at the literal top of a section make #suggestion posts in discord so people can give input, like the game market warning you put, these sort of things really need to be discussed with others first

[hugo9655]

Why did you close it? It was marked as draft for a reason.

[nbats]

I mean a lot of changes needed to be made... I figured it was easier to just sent a new one rather than editing this

[hugo9655]

Undo the phone # stuff,

Which is preferred, Phone # or Phone No.?

[nbats]

we decided on # in the past