arm7: Implement MSR fully in AICA dynarec#2391
Merged
flyinghead merged 1 commit intoJul 2, 2026
Merged
Conversation
Owner
|
Please target the |
This fixes audio in tip-of-branch KallistiOS versions, due to an FIQ enable being no-op'd.
shinyquagsire23
force-pushed
the
fix-arm7-msr-field-masks
branch
from
c10c3e2 to
450b168
Compare
Contributor
Author
|
Oh oops, it's rebased onto |
Owner
|
LGTM. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super simple PR, this fixes audio in tip-of-branch KallistiOS versions, due to this FIQ enable MSR being no-op'd with the dynarec (0xE121F000 & 0x0FBFFFF0 => 0x121f000, so the comparison to 0x0129F000 failed)
I've tested this on arm64 macOS Tahoe against my own project OpenJKDF2, and a small handful of Dreamcast games I actually owned (Tony Hawk 1+2, Crazy Taxi, Star Wars Demolition) and none had any audio issues. For the other architectures I just eyeballed the changes (but it's simple enough that it should be fine).