Remove revert bot from autosubmit.#5091
Conversation
This functionality has been replaced by a GitHub action, so we're going to remove this feature from cocoon.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request completely removes the automated revert request feature from the auto-submit service. This includes deleting the revert request validation service, the Git CLI revert method, revert-specific configurations (such as support_no_review_revert and required_checkruns_on_revert), the /check-revert-requests endpoint, and all associated tests and helper classes. Since there are no review comments provided, I have no additional feedback to offer.
| // The name of the bot that generates automated revert requests. | ||
| String get autosubmitBot => 'auto-submit[bot]'; |
There was a problem hiding this comment.
Odd that the name of the variable and the description are different. Was this used anywhere else other than revert checking?
There was a problem hiding this comment.
My understanding is that auto-submit[bot] is the name of the app associated with the key that the auto submit bot uses to interact with GitHub. The revert bot was implemented a while ago, and I think the original plan was to add more functionality (like cherry-picks) to the bot so the "autosubmit bot" would open PRs of multiple different kinds (although to be honest even this is kind of confusing, and I'm not sure why the decision was made to put this functionality into the auto submit as opposed to the dashboard service or something). However, I think the infra team at the time discovered that it was easier to implement the cherry-pick stuff through github actions, so they did so, and reverts remained the only PRs created by the auto submit bot. Now that we're removing that functionality, I think there really aren't any PRs that will be opened by auto-submit[bot] anymore, and automated pull requests are either created by GitHub workflows (which use the flutteractionsbot account) or the skia autoroller (which uses an account called engine-flutter-autroll I think).
| @@ -1,140 +0,0 @@ | |||
| // Copyright 2024 The Flutter Authors. All rights reserved. | |||
| // Use of this source code is governed by a BSD-style license that can be | |||
There was a problem hiding this comment.
Didn't realize we had discord messages for reverts. We do have a discord bot that we could use to publish messages if we see them, but I don't know what their value is.
There was a problem hiding this comment.
Hmm yeah. I'm sure I could add this functionality into the GitHub workflow if we really cared to, but maybe we should just wait and see if anyone actually cares.
jtmcdole
left a comment
jtmcdole
left a comment
There was a problem hiding this comment.
one change: make sure to remove the cron scheduler that calls the soon to be missing API. I guess we should time this landing since that will take immediate effect on Cloud.
jtmcdole
left a comment
jtmcdole
left a comment
There was a problem hiding this comment.
I missed this in the initial review:
- RevertPullRequestMutation is still present in auto_submit/lib/requests/graphql_queries.dart. auto_submit/lib/requests/graphql_queries.dart
- Which I think means
RevertPullRequestandRevertPullRequestDatastill createPullRequestCommentMockhas"body": "A reason for requesting a revert of flutter/cocoon/0 could not be found or the reason was not properly formatted. Begin a comment with 'Revert reason:' to tell the bot why this issue is being reverted."- Look for
reverts labelcomment: and
eyebrowsoffire
added
the
autosubmit
2 participants
This functionality has been replaced by a GitHub action, so we're going to remove this feature from cocoon.