Update Flutter 3.44.1#36
Merged
JSUYA merged 25 commits intoJun 10, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces Tizen cross-compilation support, including sysroot generation and toolchain configurations, and implements Vulkan external texture support in the embedder API alongside a texture LRU cache for Impeller GLES. The review feedback identifies a bug in the TextureLRU::FindTexture logic where shifting elements returns incorrect data, and a GPU resource leak due to the missing invocation of the destruction_callback in EmbedderExternalTextureSourceVulkan. Additionally, the feedback highlights ABI compatibility issues with the missing struct_size field in FlutterVulkanTexture, missing validation checks for Vulkan handles and formats, a font fallback regression on standard Linux builds, and potential network hangs in the sysroot generator script.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
JSUYA
force-pushed
the
flutter-3.44.1-candidate.0
branch
2 times, most recently
from
92e0369 to
92c5145
Compare
JSUYA
force-pushed
the
flutter-3.44.1-candidate.0
branch
from
92c5145 to
e6f204a
Compare
Member
Author
|
I have identified the code issue required for the 3.44.1 update. |
JSUYA
force-pushed
the
flutter-3.44.1-candidate.0
branch
from
e6f204a to
7e3b29a
Compare
Stop generating the GLES3 impeller shader variants in shaders.gni. Flutter 3.44 changed shell/platform/embedder/embedder_surface_gl_impeller.cc to include the impeller/entity/gles3/* headers and select GLES3 shaders at runtime via GetShaderMappings(is_gles3). With GLES3 generation disabled those headers/symbols do not exist, so adapt that consumer here: drop the gles3 includes and always use the GLES2 shader set (valid on GLES3 contexts too). This keeps the disable-gles3 patch self-consistent.
JSUYA
force-pushed
the
flutter-3.44.1-candidate.0
branch
from
7e3b29a to
7112f43
Compare
This was referenced Jun 9, 2026
JSUYA
force-pushed
the
flutter-3.44.1-candidate.0
branch
from
5eec0a5 to
e931dae
Compare
flutter-tizen/flutter-tizen#554 Added x64 artifacts for x64 emulator support (Currently, x64 Release mode is only supported on Linux hosts.)
flutter engine's window build uses Window SDKs 10.0.22621.0. window-2025 runner in gitHub actions no longer supports the 10.0.22621.0 SDK.
Add new struct FlutterVulkanTexture for embedder :
```
typedef struct {
/// Handle to the VkImage that is owned by the embedder. The engine will
/// bind this image for writing the frame.
FlutterVulkanImageHandle image;
/// The VkDeviceMemory that backs the iamge.
FlutterVulkanDeviceMemoryHandle image_memory;
/// The VkFormat of the image (for example: VK_FORMAT_R8G8B8A8_UNORM).
uint32_t format;
/// User data to be returned on the invocation of the destruction callback.
void* user_data;
/// Callback invoked (on an engine managed thread) that asks the embedder to
/// collect the texture.
VoidCallback destruction_callback;
/// Optional parameters for texture height/width, default is 0, non-zero means
/// the texture has the specified width/height.
/// Width of the texture.
size_t width;
/// Height of the texture.
size_t height;
} FlutterVulkanTexture;
```
The implement of [texture
source](https://github.com/flutter-tizen/flutter/pull/17/files#diff-7955a8522a753162869f2e8ca0017a83f4854b60800c844202e70c3aa00ff0c9R5-R204)
refer to the solution of android
platform(https://github.com/flutter-tizen/flutter/blob/flutter-3.35.3/engine/src/flutter/impeller/renderer/backend/vulkan/android/ahb_texture_source_vk.cc)
and I have submitted the code [Support render texture for
embedder](xiaowei-guan/embedder@6a94746),
I will create a new PR after[ support vulkan
backend](flutter-tizen/embedder#110) PR
released.
Replaced macos-13 with macos-15-intel actions/runner-images#13046
Because Tizen platform don't support hardware key, so we can't create a cache source to store the gpu resource. so we should reset the resouce before the frame end.
Inject a small compat header into the custom cross-toolchain command line so Linux targets built with Tizen sysroots still see __NR_getrandom even when the sysroot headers do not export it. This keeps third_party/dart untouched and fixes builds across common Tizen architectures: - x86: 355 - x64: 318 - arm: 384 - arm64: 278
Remove unnecessary CI
Adds artifact generation for x64 builds in a macOS environment. I tested the build on macOS 26.3 (Tahoe) and M4 Pro (Arm64) using the x64 lib
Store the embedder's destruction_callback / user_data and invoke it in the destructor to reclaim the VkImage; the Impeller path never released it. Reset the image view before the callback frees the image.
Reject a null embedder image handle in the texture source constructor and skip wrapping an invalid source into a TextureVK, returning nullptr instead of rendering with a half-initialized texture.
JSUYA
force-pushed
the
flutter-3.44.1-candidate.0
branch
from
e931dae to
e0338ea
Compare
The flutter-tizen embedder passes target=GL_TEXTURE_EXTERNAL_OES, so set the descriptor type to kTextureExternalOES instead of the default 2D.
xiaowei-guan
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter-tizen : flutter-tizen/flutter-tizen#773
embedder: flutter-tizen/embedder#177
These patches have been excluded. (flutter-tizen/flutter-tizen#771 (comment))