Skip to content

tests: internal: added cpu byte order test cases - #9270

Merged
edsiper merged 2 commits into
masterfrom
leonardo-master-endianness_test_cases
Aug 27, 2024
Merged

tests: internal: added cpu byte order test cases#9270
edsiper merged 2 commits into
masterfrom
leonardo-master-endianness_test_cases

Conversation

@leonardo-albertovich

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Leonardo Alminana <leonardo.alminana@chronosphere.io>
@edsiper

edsiper commented Aug 22, 2024

Copy link
Copy Markdown
Member

are these tests dependent on another PR ? (CI is failing)

@edsiper edsiper added this to the Fluent Bit v3.1.7 milestone Aug 22, 2024
@leonardo-albertovich

Copy link
Copy Markdown
Contributor Author

They are not, I'll test them in an x86 system tomorrow since that's what's failing and I only tested this on my laptop on arm mode.

Signed-off-by: Leonardo Alminana <leonardo.alminana@chronosphere.io>
@leonardo-albertovich

Copy link
Copy Markdown
Contributor Author

Interestingly enough, the issue was related to the log event encoder buffer type signedness and I didn't see it because my aarch64 linux system behaves differently to x86 systems which reinforces my opinion that PR #8851 should actually be widened in scope to ensure that this doesn't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants