in_winevtlog: Skip to translate SID for capability SIDs - #9212
Merged
Conversation
cosmo0920
marked this pull request as ready for review
August 19, 2024 05:26
cosmo0920
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
August 19, 2024 05:26
cosmo0920
force-pushed
the
cosmo0920-skip-translation-of-capability-SIDs
branch
from
August 19, 2024 05:27
a6370ff to
28728bb
Compare
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
force-pushed
the
cosmo0920-skip-translation-of-capability-SIDs
branch
from
August 20, 2024 07:16
28728bb to
0d556d5
Compare
Member
|
@cosmo0920 should this be moved to v3.1.7 ? |
Contributor
Author
|
Ah, yes. Let's move to v3.1.7. |
patrick-stephens
pushed a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Patrick Stephens <pat@chronosphere.io>
7 tasks
This was referenced Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S-1-15-3-prefixed SIDs are not mapped for friendly names.We should skip to query to retrieve associated names.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.