in_elasticsearch: Fix string in http response code 400 - #8977
Merged
Conversation
lecaros
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
June 18, 2024 14:36
cosmo0920
reviewed
Jun 19, 2024
cosmo0920
left a comment
cosmo0920
left a comment
Contributor
There was a problem hiding this comment.
These patches seems fine to me. But, could you use in_elasticsearch: prefix in your commits?
lecaros
changed the title
Signed-off-by: lecaros <lecaros@calyptia.com>
Signed-off-by: lecaros <lecaros@calyptia.com>
lecaros
force-pushed
the
lecaros-elastic-http-response
branch
from
June 24, 2024 14:12
6b1543b to
66adc67
Compare
Contributor
Author
|
@cosmo0920 Just changed the commit messages. |
cosmo0920
approved these changes
Jun 25, 2024
Contributor
|
This is trivial fix but I added v3.1.7 mile stone for not overlooking to merge this PR. |
legendary-acp
pushed a commit
to ctrlb-hq/ctrlb-fluent-bit
that referenced
this pull request
Oct 1, 2024
* in_elasticsearch: Fix string in http response code 400. Signed-off-by: lecaros <lecaros@calyptia.com>
scne59
pushed a commit
to scne59/fluent-bit
that referenced
this pull request
Apr 9, 2025
* in_elasticsearch: Fix string in http response code 400. Signed-off-by: lecaros <lecaros@calyptia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's replying with
400 Forbidden; it should be400 Bad RequestFluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.