workflow: allow equal and slash - #3306
Conversation
Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
|
Hmm. The commit checker is evidently being too picky. This is the fourth PR import re
import sys
pat = re.compile(r'^[a-z0-9\-_]+\:[ ]{0,1}[a-z]+[a-zA-Z0-9 \-\.\:_\#\(\)=\/]+$')
bad = 0
for n, line in enumerate(sys.stdin):
line = line.strip()
if not pat.match(line):
print("bad commit:", line)
bad += 1
print("%i/%i rejected (%i%%)" % (bad, n, bad / n * 100))I can confirm that the checking bot rejects ~1/4 of our historical commits: $ git log --oneline --no-merges --decorate=no | cut -d " " -f 2- | python3 a.py
...
bad commit: Core: initialization and 32 bit fixes.
1418/5933 rejected (23%)Overall, the robot seems to be rejecting tons of valid commits, and actively |
|
@fujimotos nice script! I modified script and this diff reports --- /home/taka/a.py 2021-03-31 11:28:42.256176691 +0900
+++ /home/taka/b.py 2021-03-31 11:28:24.972003619 +0900
@@ -1,7 +1,7 @@
import re
import sys
-pat = re.compile(r'^[a-z0-9\-_]+\:[ ]{0,1}[a-z]+[a-zA-Z0-9 \-\.\:_\#\(\)=\/]+$')
+pat = re.compile(r'^[a-z0-9A-Z\-_\s\,\.\/]+\:[ ]{0,1}[a-zA-Z]+[a-zA-Z0-9 \-\.\:_\#\(\)=\/\'\"\,><\+\[\]\!\*\\]+$')
bad = 0
for n, line in enumerate(sys.stdin):
|
@nokute78 Great. Can you submit that pattern as a PR with the Looking over the new pattern, I'm basically fine with your proposal. |
- allow upper case, space, '.', '.', '/' as prefix. - allow upper case character as message first character - allow '"', ''', '<', '>', '+', '[', ']', '!' '*' '\' character Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
|
I added commit to respect #3306 (comment). By the way, It is against this document e.g. |
This patch allows
=and/for commit message.e.g.
=build: fix build failure with -DFLB_SHARED_LIB=OFF (#3042)patch/build: fix cpack rules and validate flex/bisonpatchEnter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Documentation
Debug output
equal case.
slash case.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.