dockerfile: windows: Create an image of windows nano server ltsc2025 - #12219
Merged
Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
requested review from
celalettin1286,
edsiper,
niedbalski and
patrick-stephens
as code owners
August 4, 2026 10:33
📝 WalkthroughWalkthroughThe PR adds a Nano Server Windows image for Fluent Bit. It parameterizes Windows base images and updates pull-request, production, and staging release workflows for Server Core 2022, Server Core 2025, and Nano Server 2025. ChangesWindows container images
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ality Because NanoServer does not provide perflib and pdh functions on their functionalities. Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
… NanoServer Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
…2025 Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
force-pushed
the
cosmo0920-create-windows-nano-server-image
branch
from
August 4, 2026 10:35
bb53cb1 to
0119de8
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb53cb139d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pr-image-tests.yaml:
- Around line 154-176: Replace the liveness-only Nano Server checks in
.github/workflows/pr-image-tests.yaml lines 154-176 and
.github/workflows/call-build-images.yaml lines 466-488 with the same end-to-end
Forward route test: send valid multi-record and split-write payloads, verify
every accepted record appears exactly once in docker logs, exercise malformed,
null or missing-field, and boundary-size payloads, and confirm the container
remains running. Apply the equivalent test implementation at both workflow sites
so production image validation matches pull-request validation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 70d21771-988b-49f4-acf8-8b2a35d6e876
📒 Files selected for processing (5)
.github/workflows/call-build-images.yaml.github/workflows/pr-image-tests.yamlconf/fluent-bit-nano.confdockerfiles/Dockerfile.windowsdockerfiles/Dockerfile.windows.nano
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To create Windows Nano Server, we needed the following things:
After fulfilling these conditions, we're able to run Fluent Bit on Windows Nano Server.
In this PR, we just enabled only for Nano Server ltsc2025.
This is because ltsc2022 will be EOL within 6 months (until January 12th 2027).
Closes #10255.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit
New Features
Tests