Skip to content

dockefile: Install libxxhash0 on builder image - #11980

Merged
edsiper merged 1 commit into
masterfrom
cosmo0920-fill-missing-xxhash-shared-object
Jun 22, 2026
Merged

dockefile: Install libxxhash0 on builder image#11980
edsiper merged 1 commit into
masterfrom
cosmo0920-fill-missing-xxhash-shared-object

Conversation

@cosmo0920

@cosmo0920 cosmo0920 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Debian trixie has libxxhash 0.8.3-2. So, we can use it on the building process of production image.

Closes #11978.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Chores
    • Updated Docker build configuration to include an additional system dependency.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c58bdccc-b966-4a1a-af3e-490830578c8d

📥 Commits

Reviewing files that changed from the base of the PR and between 02c2f4b and 6cfe828.

📒 Files selected for processing (1)
  • dockerfiles/Dockerfile

📝 Walkthrough

Walkthrough

The deb-extractor stage in dockerfiles/Dockerfile gains libxxhash0 in its apt-get download package list. This adds the libxxhash.so.0 shared library to the extracted /dpkg/ directory included in production images.

Changes

Dockerfile deb-extractor dependency fix

Layer / File(s) Summary
Add libxxhash0 to deb-extractor download list
dockerfiles/Dockerfile
libxxhash0 is appended to the apt-get download package list in the deb-extractor stage so that libxxhash.so.0 is extracted into /dpkg/ alongside liblz4-1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • fluent/fluent-bit#11006: Modifies the same deb-extractor stage's apt-get download package list in dockerfiles/Dockerfile, directly adjacent to this change.

Suggested reviewers

  • niedbalski

Poem

🐇 A tiny lib was lost and unfound,
libxxhash0 nowhere around,
LZ4 fields went silently dark,
One line added — a small but bright spark,
Now journals flow without a bound! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding libxxhash0 to the builder image Dockerfile, which directly addresses the PR's primary objective.
Linked Issues check ✅ Passed The code change adds libxxhash0 to the deb-extractor stage, directly resolving issue #11978's root cause of missing libxxhash.so.0 dependency in production images.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to adding libxxhash0 dependency in the Dockerfile, with no unrelated modifications present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-fill-missing-xxhash-shared-object

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920
cosmo0920 force-pushed the cosmo0920-fill-missing-xxhash-shared-object branch from 80ebaf9 to 6cfe828 Compare June 22, 2026 10:48
@cosmo0920
cosmo0920 marked this pull request as ready for review June 22, 2026 11:04
@edsiper
edsiper merged commit 0481348 into master Jun 22, 2026
28 checks passed
@edsiper
edsiper deleted the cosmo0920-fill-missing-xxhash-shared-object branch June 22, 2026 23:01
@cosmo0920 cosmo0920 added this to the Fluent Bit v5.0.8 milestone Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants