engine: fix segfault in flb_config_init error case - #10355
Merged
Conversation
alecholmes
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
May 19, 2025 22:59
alecholmes
force-pushed
the
alec/2025-05-19-fix-mem-issues
branch
from
May 19, 2025 23:17
06f6213 to
df05892
Compare
leonardo-albertovich
approved these changes
May 20, 2025
4 tasks
niedbalski
approved these changes
May 20, 2025
Member
|
thanks for this contribution. note: CI was complaining about the PR subject format, it needs to be similar to the git commits, already fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a segfault in
flb_config_initthat occurs when the call toflb_config_task_map_resizefails and then callsflb_config_exit, which subsequently dereferences invalidconfig->multiline_parsers.This was picked up by the fuzzer in CI and can be reproduced on master with this input:
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Test output
Before:
After: