config: error configure_plugins_type on invalid properties

[stoksc]

After this change, when a plugin configuration contains an invalid property, configure_plugins_type returns an error which ultimately crashes fluentbit, instead of only printing an error log and continuing on. The change also fixes a small issue where name was printed by flb_error after it was freed. To properly test this change and get the test to pass with -DSANITIZE_ADDRESS=On on all platforms, I had to update configure_plugins_type to free objects that it fails to instantiate.

---

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

• [N/A] Example configuration file for the change
• [N/A] Debug log output from testing the change

Added tests, so the configuration files and outputs can be found there.

• [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

• [N/A] Run local packaging test showing all targets (including any new ones) build.
• [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

• [N/A] Documentation required for this feature

Backporting

• Backport to latest stable release.

---

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

[stoksc]

Thanks for the review, @leonardo-albertovich. I've updated the pr with the changes you requested.

[stoksc]

thanks @leonardo-albertovich, again. I've pushed a fix.

[stoksc]

do i need to squash all my commits together manually or can i squash and merge through github?

i'll try to follow https://github.com/fluent/fluent-bit-docs/blob/master/CONTRIBUTING.md, i'll post back when i've updated the commits.

[stoksc]

ok, @leonardo-albertovich I think my commits should conform to the contributing guide. what happens next? do you merge it if it passes?

[leonardo-albertovich]

Nope, it passes, I approve it, tag it if possible and ping @edsiper so he merges it when he considers it appropriate.

[edsiper]

thanks for this contribution. Code looks good to me.

To get this merged, please split the commits per interface, now there is 1 commit but 2 interfaces are being touched:

something like:

• config: ..
• tests: internal: config_format_yaml: ....

[edsiper]

thank you