out_oracle_log_analytics: fix use-after-free on flush failure - #10189
Merged
Conversation
rghouzra
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
April 9, 2025 11:21
leonardo-albertovich
suggested changes
Apr 9, 2025
leonardo-albertovich
left a comment
leonardo-albertovich
left a comment
Contributor
There was a problem hiding this comment.
Line 1202 was clearly bad but please remove the new error message, it doesn't add anything as there already is another generic message that gets emitted when this happens.
leonardo-albertovich
suggested changes
Apr 9, 2025
leonardo-albertovich
approved these changes
Apr 9, 2025
Contributor
|
Thank you! |
leonardo-albertovich
changed the title
Contributor
|
One more thing, would it be possible for you to clean up the commit history (I assume by force pushing?) to remove the superfluous commits? |
Contributor
|
I'm sharing the guidelines in case they help you amend your PR : https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#commit-changes |
Signed-off-by: rghouzra <rghouzra@student.1337.ma>
rghouzra
force-pushed
the
master
branch
2 times, most recently
from
April 14, 2025 14:14
bd212b4 to
7a8bbf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a small but important change to the
cb_oci_logan_flushfunction in theoci_logan.cfile. The change improves error handling by logging an error message when the flush operation fails instead of destroying the configuration context.plugins/out_oracle_log_analytics/oci_logan.c: Modified thecb_oci_logan_flushfunction to log an error message with the failure code instead of destroying the configuration context when the flush operation fails.