Skip to content

Incorrect signature generation leads to "Invalid signature" with non-ASCII in names #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slaFFik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Incorrect signature generation leads to "Invalid signature" with non-ASCII in names #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions includes/class-request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function __construct( $data ) {
* @return string
*/
private function create_expected_signature() {
return base64_encode( hash_hmac( 'sha1', json_encode( $this->data ), self::$secret_key, true ) );
return base64_encode( hash_hmac( 'sha1', json_encode( $this->data, JSON_UNESCAPED_UNICODE ), self::$secret_key, true ) );
}

/**
Expand Down Expand Up @@ -69,4 +69,4 @@ public function get_signed_url( $action = '' ) {
}


}
}