Harden code quality: shared Biome config + CI gate#5
Merged
Conversation
kualta
marked this pull request as ready for review
June 11, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the shared
@flow-industries/lintBiome preset and adds a lint + typecheck CI gate. Second repo in the cross-repo hardening rollout (after flow-industries/docs#29).What changed
biome.json— extends@flow-industries/lint/biome+/react; ignores CSS (Biome can't parse Tailwind v4 directives).package.json— addslint/format/check/typecheckscripts; pins@biomejs/biome@2.4.12; adds@flow-industries/lint..github/workflows/ci.yml— new; calls the reusablets-check.yml@v1workflow (lint +tsc --noEmit) on pushes and PRs.type="button"on the animated-icons copy button (prevents accidental form submits)X,Discord,GitHub,Bluesky) getrole="img"+<title>; the accordion chevron is markedaria-hiddenrole="navigation"on<nav>(pagination)==→===in field; stable keys for field error listsbiome-ignore+ reason: shadcn/Base-UIroleattributes on styled divs (button-group, field, input-group, item, carousel, breadcrumb, OTP separator), the chart<style dangerouslySetInnerHTML>(static CSS from config), and positional index keys (slider thumbs, recharts payloads). Changing those DOM elements would alter published component rendering — out of scope for a lint PR.Note on the diff
The first commit is pure mechanical formatting (57 files); the second has the wiring + semantic fixes (20 files). 8 style-level warnings remain (non-null assertions,
document.cookie) — they don't fail CI and can be burned down separately.Verified locally:
bun run lint,bun run typecheck, andbun run buildall pass.