Move git-installed deps to cosmodesi optional dependencies#73
Open
SBouchard01 wants to merge 1 commit into
Open
Move git-installed deps to cosmodesi optional dependencies#73SBouchard01 wants to merge 1 commit into
SBouchard01 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates sunbird’s packaging metadata to move several git-installed DESI ecosystem dependencies into a new cosmodesi optional dependency group, aiming to avoid repeated VCS installs (and associated CI time) in environments where those packages are preinstalled.
Changes:
- Removed
jaxand the VCS-installedcosmoprimofrom the basedependencies. - Added a new
cosmodesioptional-dependencies group containingjax,cosmoprimo(VCS), anddesilike(VCS). - Removed
desilikefrom theinferenceoptional-dependencies group.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since git-collected dependencies can't be cached because there is no versioning, those are reinstalled each time we reinstall the package - which can take a significant time, especially for ACM test jobs on GitHub workers. This is especially true for our DESI-related packages, which also have git-collected dependencies.
Luckily, those git-collected dependencies are pre-installed in the
cosmodesiNERSC environment, which allows us to create acosmodesioptional dependency group (like what was done inacm) to avoid installing them in the test environment :)This PR moves
desilikeandcosmoprimo(alsojaxjust in case) to this new optional group