Skip to content

Move git-installed deps to cosmodesi optional dependencies#73

Open
SBouchard01 wants to merge 1 commit into
mainfrom
feature/dependencies-update
Open

Move git-installed deps to cosmodesi optional dependencies#73
SBouchard01 wants to merge 1 commit into
mainfrom
feature/dependencies-update

Conversation

@SBouchard01

Copy link
Copy Markdown
Collaborator

Since git-collected dependencies can't be cached because there is no versioning, those are reinstalled each time we reinstall the package - which can take a significant time, especially for ACM test jobs on GitHub workers. This is especially true for our DESI-related packages, which also have git-collected dependencies.

Luckily, those git-collected dependencies are pre-installed in the cosmodesi NERSC environment, which allows us to create a cosmodesi optional dependency group (like what was done in acm) to avoid installing them in the test environment :)

This PR moves desilike and cosmoprimo (also jax just in case) to this new optional group

@SBouchard01 SBouchard01 requested review from Copilot and epaillas June 8, 2026 17:38
@SBouchard01 SBouchard01 self-assigned this Jun 8, 2026
@SBouchard01 SBouchard01 added the enhancement New feature or request label Jun 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates sunbird’s packaging metadata to move several git-installed DESI ecosystem dependencies into a new cosmodesi optional dependency group, aiming to avoid repeated VCS installs (and associated CI time) in environments where those packages are preinstalled.

Changes:

  • Removed jax and the VCS-installed cosmoprimo from the base dependencies.
  • Added a new cosmodesi optional-dependencies group containing jax, cosmoprimo (VCS), and desilike (VCS).
  • Removed desilike from the inference optional-dependencies group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
Comment thread pyproject.toml
Comment thread pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants