fix(psalm): resolve FastForex Psalm errors after the historical-rates refactor - #179
Merged
Conversation
… refactor - Use the Exchanger\Contract\CurrencyPair interface in processResponse() so the parent-type returned by ExchangeRateQuery::getCurrencyPair() is accepted (ArgumentTypeCoercion). - Guard the mixed values returned by StringUtil::jsonToArray() with is_string() before passing them to Exception::__construct() and DateTime::__construct() (MixedArgument). - Drop the unused Exchanger\CurrencyPair and Exchanger\Exception\UnsupportedCurrencyPairException imports (no longer referenced after the refactor). - Refresh psalm-baseline.xml: replace the stale MissingOverrideAttribute entry for the removed getExchangeRate() method with entries for getLatestExchangeRate / getHistoricalExchangeRate, and drop the now-unused MixedArgument and ParamNameMismatch baselines.
… baselines - Replace the chained ?? assignment (which still produced a mixed type) with an explicit isset+is_string ladder so Psalm can narrow each branch before passing the value to DateTime::__construct. - Drop the two MixedArgument baseline entries for $this->options[self::API_KEY_OPTION]: those call sites no longer trigger MixedArgument, and keeping the entries was producing UnusedBaselineEntry failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.