Introduce PLAY_SERVICES_VERSION - #649
Closed
mkuklis wants to merge 1 commit into
Closed
Conversation
Owner
|
Hi @mkuklis, Good point! Thanks for the pull request. I have updated the plugin with it and another change (instead of merge the PR directly) |
Author
|
Thank you @floatinghotpot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @floatinghotpot this PR introduces a
PLAY_SERVICES_VERSIONvariable in order to allow for specifying what version ofcom.google.android.gms:play-services-adswe want to use.It could be use like this:
cordova plugin add cordova-plugin-admobpro --variable PLAY_SERVICES_VERSION=11.0.8I'm one of your customers and I've been using your plugin for a while now. Unfortunately we are running into versioning issues when using cordova-admob-pro with other plugins. This change will help us a lot. I also just noticed another PR: #645 which I think asks for the same change.
Could you please merge this in? Thank you!