[Overlay] Fix hit-testing via declared interaction regions - #273
Merged
Conversation
Siri Shortcut phrases must contain \(.applicationName); a hardcoded "Find Flipper" phrase fails App Shortcuts validation and breaks the build.
Replace private hit-test traversal (relied on UIHostingController view hierarchy internals that broke on iOS 18 and again on iOS 26) with an explicit interaction mode each overlay declares: fullscreen blocks all touches, regions([CGRect]) passes through everywhere else. Also adds an Options screen to manually verify tap passthrough for notifications, alerts, and popups.
Wrap the Options debug menu entry in #if DEBUG alongside the existing Infrared layouts item so it is compiled out of Release.
Fix App Shortcuts phrase missing applicationName placeholder
Mirrors the setup from busy-app/iOS: automated PR review via Pullfrog, XcodeBuildMCP wired to the Flipper(iOS) scheme, and a CLAUDE.md (symlinked as AGENTS.md) describing build/test commands and package architecture.
Auto-lints .swift files with SwiftLint right after Claude edits them, using the project's Flipper/.swiftlint.yml config, with a fallback to the vendored Flipper/swiftlint binary if the system one isn't installed.
Set up LLM tooling: MCP config, CI review, CLAUDE.md
Replace private hit-test traversal (relied on UIHostingController view hierarchy internals that broke on iOS 18 and again on iOS 26) with an explicit interaction mode each overlay declares: fullscreen blocks all touches, regions([CGRect]) passes through everywhere else. Also adds an Options screen to manually verify tap passthrough for notifications, alerts, and popups.
Wrap the Options debug menu entry in #if DEBUG alongside the existing Infrared layouts item so it is compiled out of Release.
…lipper-iOS-App into fix/overlay-hit-testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace private hit-test traversal (relied on UIHostingController view hierarchy internals that broke on iOS 18 and again on iOS 26) with an explicit interaction mode each overlay declares: fullscreen blocks all touches, regions([CGRect]) passes through everywhere else. Also adds an Options screen to manually verify tap passthrough for notifications, alerts, and popups.
Tested on ios 16, 17, 18, 26